Van Halen’s use of it was indeed clever, and it served them well. The one time they played without the M&Ms bowl, a tech almost got electrocuted. After that they were very strict about it.In the case of the Van Halen rider, the "no brown M&Ms" clause was a stroke of genius.
Along with all of the requests for booze, towels, food, and more are often some very specific and important technical requirements. Many of these technical requirements have safety implications. The M&Ms clause was a quick and easy way to see if the local venue had read the rider and complied with the requirements. If the M&Ms bowl was free of brown candies, chances were good that everything else in the rider was acceptable. If the bowl was missing, or contained brown candies, the entire rider probably needed to be reviewed to make sure that everything was available and safe for a quality performance.
https://www.vulture.com/2020/10/eddie-van-halen-brown-m-and-ms.html
I think the sentiment though is that other artists including frivolous items is only annoying and unnecessary. The M&Ms trick is well-known by the public 40 years on and big venues are probably better-equipped these days.